Skip to content

Make WebIdentityTokenFileCredentialsProvider implement AutoCloseable #3440

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

davidh44
Copy link
Contributor

Motivation and Context

WebIdentityTokenFileCredentialsProvider currently does not implement AutoCloseable, which means that the StsWebIdentityCredentialsProvider that it creates does not close its STS client, causing memory leaks.

Fixes #3270

Modifications

Implemented SdkAutoCloseable interface and added close method

Testing

Screenshots (if appropriate)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated LaunchChangelog

License

  • I confirm that this pull request can be released under the Apache 2 license

@davidh44 davidh44 requested a review from a team as a code owner September 26, 2022 22:38
@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 22 Code Smells

92.4% 92.4% Coverage
3.0% 3.0% Duplication

@davidh44 davidh44 merged commit 0939324 into master Sep 27, 2022
@davidh44 davidh44 deleted the hdavidh/webIdentityTokenFileCredentialsProvider-implements-autoCloseable branch September 27, 2022 00:11
aws-sdk-java-automation pushed a commit that referenced this pull request Nov 14, 2024
…37787a7eb

Pull request: release <- staging/8e6cf81f-a7bd-413f-9554-d8c37787a7eb
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WebIdentityTokenFileCredentialsProvider is not AutoClosable, causing memory leak
2 participants